https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026
--- Comment #4 from Florian <[email protected]> --- I did take a look at other countries' exit code to make sure none would be penalized by this regex, and from what I could find online, all of your examples would still work. The regex isn't exactly foolproof but it should be flexible enough to allow for all valid phones numbers. I did consider the alternative of switching the SMSAlert input field from a text to a tel, since it seems to naturally check for valid phone numbers. > That's interesting. > > So that 00 is an exit code which is very country specific, so I don't think > this patch will work in all contexts. While I wouldn't call it Euro-centric > per se, since 00 is used elsewhere, it doesn't cover all international use > cases. > > For instance, the exit code for Australia is 0011 (instead of 00). > Canada/USA is 011. Russia is 810. Some places like Israel also use carrier > codes instead of exit codes. > > Perhaps we should have a system preference that allows a library to specify > 1+ exit codes to use in lieu of a "+" for the regex. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
