https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #24 from Thibaud Guillot <[email protected]> --- (In reply to David Nind from comment #22) > (In reply to Thibaud Guillot from comment #21) > > > Also for the description, my english is not as good as i would like ^^ so I > > change this too. > Hi Thibaud. > > Thanks for incorporating my suggestions - writing things in another language > can be challenging, so hopefully that is where testing can help! > > I've retested, but for some reason highlighting doesn't seem to be working > for me now - with either 'Highlight' or 'Don't highlight' selected for the > new system preference. > > Also, I would suggest: > > - Setting the default to 'Highlight' (that is, leave the current behavour in > place) (I'm not a developer, but from reading the code it should do that, > but I'm not sure why it isn't). > > - For the patch add the bug number at the start, that is: Bug 20398: > Added... (the QA Team will most likely pick this up). > > David Yes David you are absolutely right, yesterday when I rebased the patch I forgot to change some variable names on the script that manages the feature... my apologies, now its works. And I adjust the commit by the way with the bug number :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
