https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #19 from Jonathan Druart <[email protected]> --- 1. Empty new line at the top of Koha/Patron/Messages.pm 2. Koha::Patron::Messages->unread should be ->filter_by_unread 3. You don't need unread_count, just use ->filter_by_unread->count 4. Missing tests for this new method 5. DBIC schema change should not be included in the patch 6. atomicupdate file has a qq{} but you don't need string interpolation (ie. replace with q{} 7. atomicupdate is too verbose, but RM can deal with that 8. Wrong copyright statement in opac/dismiss_message.pl (the one from 2009) 9. Unexpected comment in opac/dismiss_message.pl # no warnings qw/once/; # my $ig = 'Examine variable $exception'; # push @DB::typeahead, 'x $exception'; # $DB::single++; # uncomment assignment below if you want to view environment # $result->{env} = \%ENV; 10. It would have been better to write a ajax script, like opac/svc/checkout_notes 11. What are you doing with $result? $inputs and comment are returned from the dismiss_patron_message sub but never reused. This script could be 10 lines long IMO. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
