http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |[email protected] --- Comment #27 from Paul Poulain <[email protected]> --- QA comment: * passes koha-qa.pl, except for a POD mistake revealed in C4/Suggestions.pm, I attach a follow-up fixing this problem * the patch work as expected, no side effect or any problem spotted. However, I won't pass QA this patch immediately because I've 2 questions = why is this tool in the acquisition module ? It is not specifically related to acquisition ? I think it's something that looks like the /cataloguing/addbooks.pl, that searches in the catalog and the reservoir. Shouldn't we replace the cataloguing/addbooks.pl by this new script (on which we would add a "reservoir" tab) ? Once the librarian has done his search, we could have, instead of just "New record" (to catalogate a new biblio), a "New record" and a "New suggestion" button. That would improve consistency imo. I won't fail QA for now, waiting for patch authors opinion. That will require more effort, but I think it's worth it, because it will both improve Koha functionally, usability, and code quality. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
