https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|Add messaging preferences |Add messages to batch |to batch patrons |patrons modification |modification | --- Comment #3 from Katrin Fischer <[email protected]> --- Hi Jeremy, 0) Please assign yourself the bugs you plan to work on :) 1) QA test tools A good habit to start is to always run the QA test tools against your patches before submitting, so simple stuff doesn't get your patches sent back: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt FAIL filters missing_filter at line 265 ( [% patron_message.message %] <br>) FAIL tools/modborrowers.pl FAIL spelling bloc ==> block For adding the filter, this might be helpful in the future: misc/devel/add_missing_filters.pl 2) Code comments in English please :) + # Créer un bloc pour enregistrer en bdd l'update de la table patron_messages + sécurité : 'si' tel champ est remplit alors.... etc Can you please provide a follow-up and switch back to signed off? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
