https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #857 from Marcel de Rooy <[email protected]> --- (In reply to Marcel de Rooy from comment #856) > Created attachment 131257 [details] [review] > Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber > > The fines cron job uses Getoverdues to pass issue info to CalcFine. > It took me a while to realize that the overdue hash does not contain > a biblionumber. When testing CalcFine, we pass an item hash that > does include one. > > So what happened? $item->{biblionumber} is undefined when it comes from > Getoverdues and no recall overdue fine is calculated, only a regular one. > > Simple fix (without any impact): Add a biblionumber to Getoverdues. > > Signed-off-by: Marcel de Rooy <[email protected]> > Tested with fines.pl: recall fine applied now. > Ran some Circulation and Overdues unit tests. This was a serious bug! The fines cron job would never ever calculate the correct recalls fine when you relied on Getoverdues without biblionumber.. I didnt see any reference to testing this process in the large test plan btw ;) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
