https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560
Alex Buckley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #45 from Alex Buckley <[email protected]> --- (In reply to Nick Clemens from comment #39) > Hi Alex, > > This looks good, that's a long column name :-) > Few things: > 1 - We should check the itemtype outside of the loop, I would actually check > it before loading and parsing the pref > 2 - You can use effective_itemtype to avoid the conditional, in fact there > is a fetch of that in code above, so you just need to get the object > 3 - I am not sure what the behvaiour should be if the itemtype isn't defined > or doesn't match a defined value - just mentioning as it may error when you > try to fetch the object Hi Nick, My apologies for my slow response! I think I've implemented your suggestions from comment #39 now. I have handled point 3 by checking if the object for the effective_itemtype is defined before fetching the updatenotforloan value. I've also shortened the column name to itemtypes.updatenotforloan, hopefully that is better too. Would you mind re-testing? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
