https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327

Marcel de Rooy <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |[email protected]

--- Comment #34 from Marcel de Rooy <[email protected]> ---
From the third patch:

             my $delimiter = C4::Context->preference('CSVDelimiter') || ';';
+            $delimiter = "\t" if $delimiter eq 'tabulation';

         my $delimiter = C4::Context->preference('CSVDelimiter') || ',';
+        $delimiter = "\t" if $delimiter eq 'tabulation';

+            my $delimiter = C4::Context->preference('CSVDelimiter') || ',';
+            $delimiter = "\t" if $delimiter eq 'tabulation';

In addition to last comment of Jonathan, if we are adding a function now to
control behavior, we should not need to 'fiddle' anymore like in the above
lines. Call the function and thats it.

Which probably means move the function out of the template plugin, and only
leave a wrapper there.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to