https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
--- Comment #41 from Jonathan Druart <[email protected]> --- (In reply to Tomás Cohen Arazi from comment #40) > Ok, it works. Tests pass. > > The question is: is this what we want? > > We are basically moving column descriptions handling into a better place > (i.e. a Koha class that is more normal that what we had before), we are > getting rid of a mix XML (columns.def) or json where those descriptions > lived. > > But on doing so we are: > - Moving translatable strings to Koha::* > - Adding some overhead by the way we use __. > > It feels like overall is ok, but the descriptions should live in an external > per-language file that is translated 'the usual way' and loaded only once > when the class is instantiated (class?, it should be a proper class, so each > process that instantiates it can initialize it with the current language). Why is it bad to use __()? It will get translated the usual way by translators. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
