https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855
--- Comment #21 from Michael Hafen <[email protected]> --- (In reply to Jonathan Druart from comment #20) > Your patch felt a bit dirty at first but I don't have anything else to > suggest actually. > I've added a follow-up patch to tidy a bit the code around your changes. > > I am wondering about the "$counted" variable. When do we need to increment > it? In my understanding it's correct with my patch (and was not before) but > I am not 100% sure. I'd say you are right about the $counted variable. You're follow up looks good. I prefer having the 'has the issue changed' check be closer to UpdateFine(), so that the chance of a race condition is as small as possible. But I could let that slide. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
