https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #24 from Kevin Carnes <[email protected]> ---
(In reply to Victor Grousset/tuxayo from comment #23)
> I might be mixing stuff up. I though is was about a config switch or syspref
> to avoid querying the ES version.
> 
> Is this still about this? Or is that index not a performance issue to query
> the version when indexing?
> 

It was checking the version of Elasticsearch and Search::Elasticsearch to see
if it was necessary to include the type.

The alternative solution uses include_type_name to delay removing type names.
It will work starting with Elasticsearch 6.7 and Search::[email protected] and
it will also work with Elasticsearch 7, but will give a deprecation warning.

It will work as long as support before 6.7 is not required and support for 6
will be dropped before adding support for version 8. When support for 6 is
dropped, Koha shouldn't include_type_name or use type names.

I don't think it's necessary to reindex between upgrades. There's only support
for one type name in Elasticsearch and it doesn't seem to cause a problem if
the name was data, but there's nothing wrong with reindexing in Elasticsearch
7.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to