https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517
Nick Clemens <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #30 from Nick Clemens <[email protected]> --- Martin's follow-ups here added a decent bit of functionality, so this needs another QA run. I love this enhancement, I think partners will find it useful, but I have a few concerns: 1 - In a larger consortium this could start to have performance impacts as we iterate through all the lines 2 - We are moving from SIPConfig to syspref control - I like this, but as above it removes config per SIP login to global 3 - The syntax is non-standard, I would love to see this use YAML, that could allow for things like 'field_value:X' and 'compare_field:holdingbranch' rather than '\$holdingbranch' I don't think these are blockers, as it is this is simple and straightforward, so I don't want to mess with that. Leaving for another QA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
