https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
--- Comment #58 from Marcel de Rooy <[email protected]> --- Reading this back while looking at changes between structure and actual tables, I am not so sure whether this patch (Move -- to COMMENT) was such a good idea. Note that this is an understatement. When you add a COMMENT to structure, you should add a db revision too with that clause for that field. Note that DBIx schema files also include those comments. Since this patch set only touched structure and did not add dbrev's, we will have as a result a very large set of differences between DBIx schema and the tables. I have been working on resolving differences for a 20.11 database, but I am now already looking forward to the massive output of the dbix script when I upgrade to 21.05 or higher ;) Note that running dbix script to get those differences would be very useful but will be hugely obscured by the move in this patch set. What can be done about it? Remove the COMMENT clauses again (revert) ? Adjust dbix script to remove comments (feels like a hack) ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
