https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <[email protected]> --- I have added a follow-up to fix the missing TT filters, but there are 2 issues that are a bit more than QA can fix: 1) Tests are failing Changes to any core routines in C4 and Koha need to be accompanied by unit tests per the coding guidelines, but there is a little more here as the existing tests fail with the patches applied: prove t/db_dependent/AuthoritiesMarc.t t/db_dependent/AuthoritiesMarc.t .. 2/12 # Failed test 'test BuildSummary for MARC21' # at t/db_dependent/AuthoritiesMarc.t line 158. # Structures begin differing at: # $got->{equalterm} = ARRAY(0x563fe77a47f0) # $expected->{equalterm} = Does not exist # Failed test 'test BuildSummary for UNIMARC' # at t/db_dependent/AuthoritiesMarc.t line 202. # Structures begin differing at: # $got->{equalterm} = ARRAY(0x563fe36e6b00) # $expected->{equalterm} = Does not exist Cannot determine authority type for record: 1710 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 566. t/db_dependent/AuthoritiesMarc.t .. 12/12 # Looks like you failed 2 tests of 12. t/db_dependent/AuthoritiesMarc.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/12 subtests Test Summary Report ------------------- t/db_dependent/AuthoritiesMarc.t (Wstat: 512 Tests: 12 Failed: 2) Failed tests: 6, 8 Non-zero exit status: 2 2) Hardcode delimiter This hardcodes the delimiter for subheadings to "--", but I believe it should be using the system preference AuthoritySeparator instead. Please let us know if you need help in fixing those. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
