https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677
--- Comment #10 from Andrew Nugged <[email protected]> --- I want to propose as QA-phase only this: That "if" is _probably_ not needed: ... if $q =~ m/.*(isbn|ean|publisher).*/; because this anyway matches only those places: $q =~ s{biblio\.(?=isbn|ean|publisher)}{biblio\.biblioitem\.}g; so having this: $q =~ s{biblio\.(?=isbn|ean|publisher)}{biblio\.biblioitem\.}g if $q =~ m/.*(isbn|ean|publisher).*/; is something like "double-check for the same thing", But this is more like 50/50 proposal to agree with you JD/Martin. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
