https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139
--- Comment #16 from Shi Yao Wang <[email protected]> --- (In reply to Katrin Fischer from comment #14) > (In reply to Shi Yao Wang from comment #13) > > Copy pasted the same function into paycollect.tt > > Hi Shi, please don't add changes to your patches after the patches have been > signed and QA. This is not what people tested - please always provide the > changes in a separate patch. > > I'd also be inclined to say it should maybe be a separate bug and also have > a new test plan. I had tested paying fines and had no issue - where and why > is the new change needed? Noted, thanks for letting me know. I sent the changes because both files had the exact same function. It seems inconsistent to have 2 functions with the same name, but with different code. I guess it doesn't really matter if the other one doesn't have any issue in the first place. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
