https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730
Martin Renvoize <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <[email protected]> --- Good spot finding 'SkipHoldTrapOnNotForLoanValue' David, to me that pref is slightly mid-described.. it feels like it should affect not just trapping at checking but also this HoldsQueue and pendingreserves too. For history, the notforloan handling was dropped from here by mistake originally in bug 3142 where it looks like we assumed the same logic was already taking place in the filter_by_for_hold. (Bad assumption.. we go from filtering on `!= 0` to filtering on `'<=' => 0` An initial 'fix' would be to restore the `!= 0` found in get_items_that_can_fill I believe.. though I'm not sure how the chaining would treat it.. I'm not entirely a fan of the current implementation in this patch.. your adding a query to fetch all items available for loans instead of just adding the 'notforloan' limit to the existing overall query. I'll have a read of the unit tests now to check they make sense, then I think we can golf this a little further. As for the 'SkipHoldTrapOnNotForLoanValue', that might be a nice thing to add support for whilst we're here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
