https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Katrin Fischer <[email protected]> ---
1) QA test tools:

 FAIL   installer/data/mysql/atomicupdate/update-BZ_10762.pl
   FAIL   file permissions
                File must have the exec flag

2) See comment#11, it looks like the original value was 0.01:

+            scale_height    =>      0.02,

-    my $barcode_y_scale_factor = 0.01 * $self->{'height'};              # this
scales the barcode height to 10% of the label height

3) Defaults

Just a question, maybe someone else can answer that one too:

The patch adds the 2 new database columns with defaults 0.02 and 0.8 in the
database and also sets the defaults in new. 

Should we do both or would one option suffice?

4) Changes to kohastructure.sql are missing

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to