https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733
--- Comment #35 from Victor Grousset/tuxayo <[email protected]> --- Rebased. --- (In reply to Fridolin Somers from multiple comments!) > Some breadcrumbs have a IF/ELSE on action (like add/modify) on an object. > We need to keep the action and the object together because of some languages > like French. Great catch thanks! Fixed. --- > In koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-bib-search.tt : > [...] > I think the template is wrong even before this change. > This should be wrapped in a "title" tag. > Since it is the title tag, HTML tags are not allowed. > Maybe we can create another bug report for that. > Idem in opac-account-pay-error.tt After investigating these with you (thanks for the help :D) we are nearly sure they are dead code. I will open followup tickets. As the for changes of this patch they can stay there. They have no impact beside cleaning translation strings. --- > In koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt > [...] > Why this small change ? It was so "[% ELSE %]Item[% END %] overdue as of" is extracted and the context is kept. But it doesn't look great on a second though to leave "Items" in the IF without context. I undid it. And might handle it in a followup string cleanup patch using t() with proper plural handling. --- > Maybe add span also around "Biblio-level recall on..." Extracted string is «%s Biblio-level recall on» , I lacked time for those not really terrible strings. Done now. --- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-ics.tt > This is for ICal calendar export, maybe it should not contain HTML Great catch! Undone. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
