https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789
--- Comment #11 from Nick Clemens <[email protected]> --- (In reply to Marcel de Rooy from comment #10) > (In reply to Nick Clemens from comment #9) > > (In reply to Marcel de Rooy from comment #8) > > > I agree with this patch, no problem about that. > > > But the performance gain should be close to zero. > > > Running Biblio.t (calling AddBIblio) twice with and without patch: > > > RM: I would suggest to revise the title unless we have clear feedback to > > > prove the statement. Keeping the release notes a bit more realistic? > > > > The gain is only going to come when you have records that contain items. > > > > Testing with NYTProf against an import with record containing items, there > > was a clear improvement > > > > Biblio.t does not add items to most records, so the savings will be minimal > > if present > > When you look at the AddBiblio code, you will be surprised to see that this > routine does not add items at all. > During import you need something as BatchCommitItems to add items. > > So the title of this report still needs attention :) That's exactly the issue - we aren't adding items, but we are processing item fields - what would you suggest for the bug title? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
