https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
--- Comment #61 from Kyle M Hall <[email protected]> --- Created attachment 135951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135951&action=edit Bug 25711: (QA follow-up) Refactor to clarify logic At the point where 'ExpireReservesMaxPickUpDelayCharge' can/should kick in, we should already have an item waiting (else what's triggered a pickup delay). As such we can drop the fall through default of using the syspref when we don't yet have an item. We can also save us some calculations and database hits by only calculating the charge value when we've actually been asked to charge. So we also move the block inside the 'charge_cancel_fee' block. Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Petro Vashchuk <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Kyle M Hall <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
