https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522
--- Comment #16 from Katrin Fischer <[email protected]> --- Hi Aleisha, sorry for taking so long to give feedback on this patch. It took a while to wrap my head around and I hope my notes make sense. > Thanks Katrin - the host item feature isn't something I've used before so > some context and more specific feedback would be useful! I'll try! We'd create an analytical record a litle different than in your test plan, as we can't use the EasyAnalytics feature that relies on creating 773 fields in the MARC record. For our records the union catalog is the primary database and the link between the record and its host item would be created there. This would resemble our workflow a little better in Koha: * Search for a serial or monograph record in the staff interface * From the detail page: New > New child record * This opens a new record in the cataloguing editor with a 773 created from the information of its 'parent' record. If you are using controlnumber for linking, the 001 of the host will be in $w of the child used for linking by ID. * Add 773$g with information on the location of the 'child' within the 'parent' (i.e. volume, issue, pages) Example: $g 13(1917), 12, p. 98-104 There is sample record set on bug 11175, that's a good starting point. For testing I have added $g and removed $w in some records. =XSLT based displays (list view in OPAC)= * I think currently the result page uses a copy of the 773 code from the detail page, but they have fallen out of sync. For example missing the change from bug 20277. Could you please move the code into MARC21slimUtils.xsl as a new template, so we can use the same logic in detail and result page? Nick did something similar on bug 5927. * We should probably note in the test plan that the changes to the XSLT will also apply to the normal result list in the catalog and staff interface. =TT based displays (cart detail, list detail, cart email, list email)= You used get_marc_host for finding the host record and the include for displaying the title here, which I think is a neat approach. I really like that it allows us to create a direct link using the biblionumber instead of the more complicated search link using $w or $a$t. But as usual, there are some caveats with libraries. :( At the moment the 773 will only show when the library has been using $w/001 for linking, which is often not the case. We also have some cases, where an 'unlinked' 773 without $w will be added/imported in our catalogs. * It would be nice if we could still be using get_marc_host somehow, but we might need at least a fallback to create the display using 773$atg directly. 773 should only display if there is at least a $t. I think when there is no $w just displaying the plain text without a link would be ok and still a nice improvement. * Can you please add 773$g to display? It looks like get_marc_host will return it if called in list context. * virtualshelves/sendshelf.pl still has $biblio->get_host_item_entries, maybe from a previous version of this patch? * Release notes and test plan also mention $biblio->get_host_item_entries, but I think it was replaced by get_marc_host. * The FOREACH in the templates might not be needed if we keep using get_marc_host as it only looks at the first 773. * The 'label' for 773 is usually "In:" in the detail and other views. Can you please make the TT views match? Currently they are using 'Host item entry' or 'Host item entries' or 'Source' (XSLT results). About comment#14 from David: * I couldn't test the email part, apart from reading the code, but maybe you could check the the links? I'll certainly try his test plan for email next iteration :) * I didn't have the issue with the cart in the staff interface that David noted, but I think the list issue is due to the wrong method name. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
