https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30991
Bug ID: 30991 Summary: [% ELSE %]0[% END %] will break translations if used for assigning variables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr See bug 30958 and bug 23713: The construct with the 0 will break on translation as it's removed in the translated templates: > The problematic line (below) in the English template is: > var OD_password_required = [% IF > Koha.Preference('OverDrivePasswordRequired') %]1[% ELSE %]0[% END %]; > > Which is translated to the following in the en-NZ (and other languages) > template: > var OD_password_required = [% IF > Koha.Preference('OverDrivePasswordRequired') %]1[% ELSE %][% END %]; We should verify that there are not more occurences of the bad pattern or improve our translation scripts: (In reply to Owen Leonard from comment #3) > There are a couple of other instances that I saw which should also be > addressed. I searched the NZ templates for "1[% ELSE %][% END %]" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/