https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
--- Comment #257 from Katrin Fischer <[email protected]> --- (In reply to Martin Renvoize from comment #256) > (In reply to Katrin Fischer from comment #224) > > > I'd also make the button just "Delete" or "Yes, delete", but that's a > > personal preference and I see that this was 'copied' from how deleting a > > patron category looks like. > > Hmm, I'd love to see us standardise on something and create a guideline > about it.. at that time I'd be keen to go through and get everything > consistent. Agreed, I was just wondering, because in German such buttons tend to get huge. > > > 3) After installing/updating with this patch, MANUAL is marked es the > > default. You cannot change it, until you have added a new restriction, which > > makes sense, as the system internal ones should not be default. But: you > > cannot ever change the default back to MANUAL. I think this is because > > system internal values are excluded, but it might raise complaints for > > people experimenting with the feature that want to restore previous > > behavior. > > I discovered the update and the install data were out of sync.. fixed in a > follow-up. This resolves the defaulting issue. Good catch! Will retest. > > 5) When adding a manual restriction to the patron account, the default seems > > to be only used when PatronRestrictionTypes is off, when it's on and the > > pull down shows, the default is not preselected, but the first entry is. > > Hmm, I couldn't replicate this. I'll retest. > > 8) I notice that the type itself doesn't show up in the OPAC or the note on > > the patron account in staff, just the comments do. This is the case with and > > without the patches, maybe something so consider later. Or we could imagine > > adding a default comment? (no blocker, just loud thinking) > > Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one? Yes, loud thinking definitely warrants a separate bug. I'd also not noticed that before, but it's unchanged by this patch set. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
