https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042
--- Comment #7 from Martin Renvoize <[email protected]> --- Comment on attachment 136693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136693 Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to block Review of attachment 136693: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22042&attachment=136693) ----------------------------------------------------------------- Sorry Nick.. this doesn't look quite right yet.. ::: C4/Circulation.pm @@ +2096,5 @@ > > + if ( $item->withdrawn ) { # book has been cancelled > + $messages->{'withdrawn'} = 1; > + $doreturn = 0 if > C4::Context->preference("BlockReturnOfWithdrawnItems"); > + return ( $doreturn, $messages, $issue, ( $patron ? > $patron->unblessed : {} )); This doesn't look quite right to me.. we're returning early now regardless of the BlockReturnOfWithdrawnItems preference? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
