https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212
Andreas Roussos <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Andreas Roussos <[email protected]> --- Hi Michal, I concur with Sally; your patch, as it stands, does not work 100%. However, fear not! The Community is here to help! ;-) Since you're changing a column definition in the DB, you may want to have a look at these guidelines: https://wiki.koha-community.org/wiki/Database_updates The gist of it is that when you alter the database schema, you need to accommodate for both a) new installations (which you did by modifying the installer's DB structure in installer/data/mysql/kohastructure.sql), *and* b) existing installations by means of creating an atomicupdate file. Also, since the DATETIME column will now be able to store the exact time the item was last seen down to the second, you'll have to ensure the timestamp is stored with the correct accuracy in the DB. Finally, don't forget the unit tests whenever you want to submit a patch, as they can help you find oversights in your submitted code. As usual, the details are in the Wiki: https://wiki.koha-community.org/wiki/Unit_Tests#Good_practices_for_running_tests I hope this helps! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
