https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #17 from Tomás Cohen Arazi <[email protected]> --- Comment on attachment 138123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138123 Bug 25870 - Add a q_ccl query parameter to /biblios Review of attachment 138123: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25870&attachment=138123) ----------------------------------------------------------------- ::: Koha/REST/V1/Biblios.pm @@ +160,5 @@ > + my $record_processor = Koha::RecordProcessor->new( > + { > + filters => 'ViewPolicy', > + options => { > + interface => 'opac', I think you could implement only a list() method, and rely on $c->stash('is_public') to choose staff vs. public. And later check the OpacHiddenItems stuff accordingly. @@ +177,5 @@ > + } > + ); > + } > + > + sub format_record_by_content_type { This inline subs look really untidy. @@ +243,5 @@ > + } > + > + my $response = > + format_record_by_content_type( > + { content_type => $requested_content_type, records => \@records > } ); It feels like this method call should be placed in the data => portion of the respond_to, with the right parameters for each case instead of 'detecting it' inside format_record_... But as I said, I'm still not convinced by those subs. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
