https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
--- Comment #107 from Katrin Fischer <[email protected]> --- o) Tests are failing, but possibly just a typo/later change causing it: # Failed test 'Notice correctly generated' # at t/db_dependent/Koha/CurbsidePickups.t line 299. # got: 'You have schedule a curbside pickup for Te9oDc' # expected: 'You have schedule a curbside pickup for Te9oDc.' # Looks like you failed 1 test of 2. Other finds from code review: 1) Tiny typos * Curbside pickups are not enabled for your location. = library * Pickup Date/Time = capitalization * ... it is an holiday = it is a holiday. (multiple) * Deliver Date/Time = capitalization * There is no waiting holds for this patron at this location. = There are no... at this library * No pickup time define for this day. = defined (multiple) * You don't have waiting holds at this location = library 2) New JS libraries There are no license statements for these, as we only add the minified version: dayjs.min.js isSameOrAfter.js customParseFormat.js Should they be listed on the about page? Please check! I'll keep testing on GUI side. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
