https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <[email protected]> --- Hm, I think think this doesn't fix what was reported as the bug initially: comment#1 The seasonal (season, day and month) prediction it doesn't change according the locale defined in the patterns, the pattern uses always the language of the staff user interface. I believe that the expectation here is that it should work like months/day of week do. You should be able to use the Locale setting of the subscription to determine the language used for the generated strings, so that it matches with what is printed on the issue. These are not meant to be multi-lingual, but to match the 'original' printed version. What this patch does is actually the bug: It makes the description switch depending on the GUI language used. Before this patch (tested in 20.11): Staff interface: German Locale: German Preview pattern: German Serial collection: German Edit serials: English OPAC: English Database: English With this patch set: Staff interface: *English* Locale: Spanish Preview pattern: English Serial collection: English Edit serials: English OPAC: English Database: English Update translations, switch interface to German: Staff interface: *German* Locale: Spanish Preview pattern: German Subscription detail view: German Serial collection German Edit serials: English (!) (input fields) Database: English Staff detail view: German Late issues/claims: German OPAC detail page - Subscription: English OPAC brief history: English Full history: English Conclusion: 1) This makes the display more consistent in the staff interface. OPAC has been missed and should work the same as staff. 2) Locale setting is ignored for seasons. This makes seasons work different to the other formatted strings. This doesn't sit well with me, because it's also an inconsistency, but I am not sure there is a fix as I believe the library used for other strings just doesn't support seasons. :( If we agree on the different behavior we should document it. Suggestion: Extend the hint below the Locale pull down by: "Not used for seasons." 3) Removing the limited support for abbreviated seasons is a little issue. We can hardly remove the setting if libraries have used it, but is it really useful if it works only for English? A compromise could be to add a hint to the entry in the formatting pull down: "Name of season (abbreviated, English)" What could help here in the future would be a feature to define your own "formatted strings" as a list of authorised values (thought I had filed that... but can't find it). Codes would be numerical, AV would be the string used and we could use them to extend the list of available formats. I had requests for Roman numbering and we could also imagine someone wanting to do Japanese numbering or similar. This could help solve that issue. (I'll file later if people like it :) ) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
