https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #189 from Nick Clemens <[email protected]> --- (In reply to Jonathan Druart from comment #188) > I am pretty sure we going globally to do better with > this move, the query run by GetItemsInfo is big and is certainly the cause > of some slowness. It's the same query as GetItemsForInventory - afaict from some profiling that is much faster than our other methods, big query, but run once > We could split it up into several bugs, but my feeling is that it will add > extra work (new bug report, more people involved in SO+QA, more time to get > it in, can be released into 22.11 without all the work done, follow-ups can > be harder, same for revert if we need it) for not much benefit. Each patch that only deals with a single script is easier to SO/QA/rebase/revert if needed - removal from a single script doesn't rely on the other patches. The patches near the end with search ordered can be their own, the will touch more, but it is just verifying a single routine work It will be more people - but I think that's the benefit - more people reviewing the areas they know. When the sets are this big it is often a large commitment from a single person, and reviewing on a large level often comes out to: "Good enough, seems solid, let's catch the bugs after" I see the negative with a single bug as: large rebases/large testing plans/large time commitment and I don't see the benefit of this. Large patches move slower -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
