https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779
Tomás Cohen Arazi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #35 from Tomás Cohen Arazi <[email protected]> --- Hi, please review my follow-up patch and sign it if correct. The way the phrase was built is incorrect IMO, but I didn't find precedent uses of __x() in the codebase. Also, and important too: t/db_dependent/Koha/Cash/Register/Cashups.t .. # Failed test 'Returns only CASHUP actions' # at t/db_dependent/Koha/Cash/Register/Cashups.t line 66. # got: '5' # expected: '1' # Looks like you failed 1 test of 3. t/db_dependent/Koha/Cash/Register/Cashups.t .. 1/1 # Failed test 'search' # at t/db_dependent/Koha/Cash/Register/Cashups.t line 74. # Looks like you failed 1 test of 1. t/db_dependent/Koha/Cash/Register/Cashups.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests t/db_dependent/Koha/Cash/Register/Cashup.t ... 1/3 # Failed test 'payout_grouped arrayref is correct' # at t/db_dependent/Koha/Cash/Register/Cashup.t line 226. # Structures begin differing at: # $got->[0]{related_debit} = HASH(0x55c08306c098) # $expected->[0]{related_debit} = Does not exist # Failed test 'payout_grouped arrayref is correct' # at t/db_dependent/Koha/Cash/Register/Cashup.t line 346. # Structures begin differing at: # $got->[0]{credit_type}{description} = 'Refund' # $expected->[0]{credit_type}{description} = 'A refund applied to a patrons fine' # Looks like you failed 2 tests of 29. t/db_dependent/Koha/Cash/Register/Cashup.t ... 3/3 # Failed test 'summary' # at t/db_dependent/Koha/Cash/Register/Cashup.t line 350. # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
