https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31369
Bug ID: 31369
Summary: Koha::Recalls->add_recall should validate there's a
related checkout
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
I haven't really tried, but the code cleary relies on an $recall->checkout
returning a Koha::Checkout object... Which shouldn't be taken for granted. The
way it is constructed is fragile and makes the controller need to perform all
the checks, that really belong here. It should probably throw an exception as
well. Right now the code can generate a recall object (store it on the DB) and
then explode because of the lack of the checkout. This also points to the need
of a transaction.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
