https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395
ByWater Sandboxes <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139407|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <[email protected]> --- Created attachment 139417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139417&action=edit Bug 31395: Only try to cancel holds if item found This patch makes the code dealing with waiting holds with cancellation requests be dependent on the fact an item has been found. The returns.pl controller is a bit messy as the real return takes place outside the main `if ($item)` block. This should be refactored and probably run inside a transaction... In the meantime this patch will make the job. To test: 1. Try to return an invalid barcode (e.g. ASDQWE) => FAIL: Things explode 2. Apply this patch 3. Repeat 1 => SUCCESS: Doesn't explode! 4. Verify that returning an item with a waiting hold with cancellation requests still cancells the hold. => SUCCESS: It does! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <[email protected]> Signed-off-by: Andrew Fuerste-Henry <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
