https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <[email protected]> --- This works nicely and I quite like the idea! Only one real blocker and some notes/suggestions: 1) +=head3 get_savings (blocker) We need some unit tests here. 2) issues + old_issues (not blocker) A lot of libraries nowadays choose to anonymize the checkout history rather fast. So as we look at issues and old_issues here, the amount saved will go up and down quite a bit. I wonder if it could make sense to add a note to the pref so libraries have this in mind when activating the feature. 3) Wording (follow-up patch added) I have provided another follow-up for the reading history page following Owen's suggestion as this will also ease translation (combined constructs like x catalog are always a little hard) 4) id (not blocker) It could be nice to have a specific id on the message in the summary page and reading history in case libraries want to do some formatting or rephrasing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
