http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #33 from Jonathan Druart <[email protected]> --- Hi Jared, Great patches! In a first time I tested the patch and do not find anything to say. It seems working well. So I tried to find something to discuss, but I just found stuffs to quibble ;) e.g. 1/ I don't understand your test (t/Cache.t): ok(exists $myhash->{'anotherkey'}, 'Cache reset properly'); 2/ qa-tools had helped me! :) * Koha/Cache.pm FAIL pod FAIL *** ERROR: =over on line 281 without closing =back (at head2) in file Koha/Cache.pm forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (369) And I was going to sign off yours patches (bug 9434 and this one), but I had a last idea : check the perfs. I think we expect from this patch a gain of performance. (Results produce by NYTProf) On the preferences.pl page (admin/preferences.pl?tab=cataloguing) I got: with the master branch: admin/preferences.pl for 839ms (of 922ms), executing 180787 statements and 30350 subroutine calls in 175 source files and 39 string evals. with bug 9434 and bug 9089: admin/preferences.pl for 1.13s (of 1.27s), executing 300952 statements and 53214 subroutine calls in 183 source files and 39 string evals. On a search result page (catalogue/search.pl?q=d) I got: with the master branch: catalogue/search.pl for 1.51s (of 1.85s), executing 659967 statements and 122242 subroutine calls in 119 source files and 29 string evals. Statements | time | Module 249908 147ms Template/Parser.pm 140543 124ms MARC/Field.pm 95389 80.1ms C4/Biblio.pm 2552 70.9ms C4/Reserves.pm 23 67.4ms CGI/Session/Driver/mysql.pm 19488 37.7ms MARC/Record.pm with bug 9434 and bug 9089: catalogue/search.pl for 2.59s (of 3.19s), executing 1136765 statements and 218314 subroutine calls in 131 source files and 29 string evals. 174117 249ms Carp.pm 161178 153ms Compress/Raw/Zlib.pm 249908 139ms Template/Parser.pm 15360 134ms Compress/Zlib.pm 5067 130ms Storable.pm 140543 125ms MARC/Field.pm 3378 100ms Koha/Cache.pm It will be very difficult to gain 1 second by caching some others stuffs. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
