https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755
Martin Renvoize <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140079|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <[email protected]> --- Created attachment 140100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140100&action=edit Bug 30755: (follow-up) Add a results hash to automatic renewals It's slightly debatable whether auto_too_soon is an error or not. I think it leans far enough towards error that the other patch is correct. The change, however, will affect notices and means we cannot count auto_too_soon anymore This patch adds a new 'results' hash to the info - this includes a count per error (including auto_renew i.e. success) allowing for notices to decide how to display the info. To test: 1 - Add to Auto renew digest notice: [% IF results %] There were [% results.auto_too_soon %] items that were too soon. [% END %] 2 - Check out some items to a patron that will be too soon 3 - Check out one that is not too soon and will renew 4 - Ensure patron has auto renew digest selected and that AutoRenewalNotices is set to follow patron preferences 5 - Run the auto renewals cron 6 - Confirm the notice for the patron displays 1 successful renewal, no failures, and a correct count of too_soon Signed-off-by: Nick Clemens <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
