https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

Tomás Cohen Arazi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #38 from Tomás Cohen Arazi <[email protected]> ---
I like where this is headed to.

I think we need some more tests here, particularly for the 'staff_authorize'
and 'prepare_template', unless I'm missing something. I noticed at first glance
a subtle issue with __koha__user__ vs. __koha_user__ that is not caught by the
provided tests.

Otherwise this is great!

It would be great (also) if you could perltidy some of this code. I usually
select the code I want to tidy, and just ctrl+k ctrl+f on VScode. Please do it
inline. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to