https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #36 from Katrin Fischer <[email protected]> --- I have decided to move this to 'In discussion' for now. My reasoning: The patch set does appear to do much more than is written on the 'tin': It claims to allow for custom upload paths, but it does a lot more than that. There are unresolved questions about some of the design decisions and how we can deal with the consequences: * While Kyle had originally proposed using an AV in the initial description, this patch set moves everything away from the GUI into the koha-conf.xml. In doing so, it removes the UPLOAD AV. If this is proven to be the right path, it would require more work to remove the AV category properly and ensure a clean upgrade path (see comment#34, comment#29). But we also should discuss if this is a required step as it takes away control from libraries that often don't have easy access to server side configuration. Personally this feels contrary to what I see in other work (like making a GUI for SMTP servers). * Adds other extra features, like: > hash_filename: Whether to prepend hashvalue to the filename or not. I wonder if some of these features would be better suited as follow-ups to keep the initial bug smaller. (comment#35) My feeling is that these conceptual questions cannot be resolved in QA, but need to be resolved before it reaches the QA step with a clear test plan/upgrade path/reasoning of changes. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
