https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <[email protected]> --- Hi Emmi, there are several problems highlighted by the QA tools, can you please fix? For fixing the filters there is a handy script: misc/devel/add_missing_filters.pl. FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco-self.inc FAIL filters missing_filter at line 7 ( <a class="brand" href="/cgi-bin/koha/sco/sco-main.pl"><img src="[% interface %]/[% theme %]/images/koha-logo-navbar.png" alt=""></a>) missing_filter at line 7 ( <a class="brand" href="/cgi-bin/koha/sco/sco-main.pl"><img src="[% interface %]/[% theme %]/images/koha-logo-navbar.png" alt=""></a>) missing_filter at line 31 ( [% opacheader %]) OK koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt FAIL filters missing_filter at line 486 ( <b>[% checkinmessage %]</b>) missing_filter at line 589 ( if ( (Date.now() - confirmStart) < [% SelfCheckTimeout %] ) {) missing_filter at line 590 ( window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[% borrowernumber %]&print=qslip");) FAIL opac/sco/sco-main.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 79) forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 135) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
