https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #154 from Katrin Fischer <[email protected]> --- 1) All the new and old tests pass. But: I did a reset_all to have a clean starting page before applying these patches. And my branches are all mangled after running the tests: I end up with 36 branches on the sample database, a lot of those generated ones like: brW5iS. There are also a ton of generated patrons... I am not completely sure it's the new tests here, but could you please check your clean-up? 3) Holds queue is looking good now: a1 or any item from item_group A Just please remove the _ :) 2) Pending holds / Holds to pull > I don't think Holds to pull is the tool a library should be using if they > are using item group holds. This same is true for the holds itemtype filter, > which has been in Koha since 16.05. I'm finding the holds to pull interface > doesn't display data well. For instance, if I place one item level hold, and > one biblio level hold for the same record, holds to pull doesn't really > indicate that. If you can can tell me what you'd like to see, I'll see what > I can do! I don't think we can argue that, unless we hid the report once the item group holds are activated... and that might create quite some complaints. I know single branch libraries like to use the report, also the less busy ones. Maybe it would be worth adding a note to the system preference? "Might not go well with..." or so? In general the page needs work, I agree with you on that! I did some more testing: a) If there is a record level hold only: Only 39999000011418 b) If there is an item level hold only: 39999000005097 or any available. c) If there is a group level hold only: 39999000005097 or any available. For a start, could we catch the third case and have a correct message display? Similar to the one on holds queue? I'd be ok with that as a solution for this patch set. For the future 2 ideas (just to get your opinion, will file later): * If there are different types of holds we could display this as a note: "Different types of holds, please check holds page"? * We could repeat the information for every hold, maybe deduplicated. At the moment it looks like we only get the info for the first hold placed. Maye something like: * Only 39999000011418 (1 hold) * 39999000005097 or any available (2 holds) To summarize: * Verify/make sure tests clean up their created data * Remove _ from message on holds queue page * Adapt message when only a item group hold exists on holds to pull OK? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
