https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <[email protected]> --- 1) Unit test With the patch applied, the tests output some warn, without the patch the output is clean: prove t/db_dependent/Koha/Patrons/Import.t t/db_dependent/Koha/Patrons/Import.t .. 166/176 Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$fh> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$fh> line 2. t/db_dependent/Koha/Patrons/Import.t .. ok BorrowerRenewalPeriodBase 2) GUI I am not sure the options are described clearly as is: Update existing patron expiration dates. * Maybe instead of update it should be "recalculate"? Otherwise I would understand this as 'use the expiration date from the file'. Update patron's expiration date based on the current date instead of the patron's enrollment date * We have BorrowerRenewalPeriodBase, maybe we could have a pull down or preselect the option according to the pref? * The 2 options feel disconnected. Maybe the second should only be enabled, if the first was checked? Or use identation? * What's the supposed behaviour when there is an expiration date in the import file? Will it be used or do the checkboxes take precedence? If so, maybe we could add: ... values in the import file will be ignored. * While we are there... can we also remove the . from the only option that has it? :) 3) Test plan Can we have a test plan please? 4) CLI Marcel is right, expiration-from-today is missing: +import_patrons.pl --file /path/to/patrons.csv --matchpoint cardnumber --confirm [--default branchcode=MPL] [--overwrite] [--preserve_field <column>] [--preserve-extended-attributes] [--update-expiration] [--verbose] -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
