https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <[email protected]> --- (In reply to Katrin Fischer from comment #4) > * h1 should not be inside page section for currencies I didn't change this in my patch because presents a problem which needs to be addressed globally. Sometimes, as on this page, the H1 is inside a <legend>: <legend> <h1> <span>New currency</span> I want to look at how consistent we are with this structure and try to address it in another patch. item_search_fields.tt is a similar issue. > * auth_subfields_structure.pl - The submit/cancel are in a separate 'block', > I have also seen this on other pages. Should we make this a general rule for > our style guide? This will be addressed in another bug, and should probably be covered in the style guide. > * The save buttons for the 'new' actions on classification configuration are > not 'centered'. There is a lot more white space to the top than to the > bottom. This is essentially the same problem as the previous one. > Maybe a 'part 2' bug for this one or did I miss the single bugs? This patch wasn't comprehensive, so more work remains to be done. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
