https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer <[email protected]> --- 1) QA test tools: OK Koha/Item/Template.pm FAIL Koha/Item/Templates.pm FAIL pod *** WARNING: =head3 without preceding higher level in file Koha/Item/Templates.pm *** WARNING: =head3 without preceding higher level in file Koha/Item/Templates.pm *** WARNING: =head3 without preceding higher level in file Koha/Item/Templates.pm OK Koha/Schema/Result/Borrower.pm FAIL Koha/Schema/Result/ItemEditorTemplate.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class OK cataloguing/additem.pl OK installer/data/mysql/atomicupdate/bug_24606.pl FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column item_editor_templates.is_shared is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/ItemEditorTemplate.pm), see the SQL12 coding guideline OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/str/cataloging_additem.inc FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL filters missing_filter at line 275 ( <option data-editor="1" data-shared="[% t.is_shared %]" value="[% t.id | html %]">[% t.name | html %][% IF t.is_shared %] (shared)[% END %]</option>) 2) Why the sub in cataloguing/additem.pl instead of a module? +sub get_item_from_template 3) New cookie alert! ItemEditorSessionTemplateId If this gets pushed, please don't forget updating https://wiki.koha-community.org/wiki/Use_of_Cookies. 4) Translatability You used the old style here, which is no longer necessary: + alert(MSG_TEMPLATE_NAME_REQUIRED); You can just put the message into the .js using the double-underscore: __("") Not a blocker for me, as it looks like the other messages on this template haven't been moved yet, but not opposed to a fix either :) 5) The GUI doesn't work well with the new staff interface design. The elements don't align nicely (especialy the save template one is jumping up and down a lot with the elements) and we are missing padding. I believe we should not push without having this sorted or on the way to be sorted. - We want to advertise and document this feature and then it should look nice! 5) When using "Add multiple items" all other buttons disappear, but the "Save as template" remains. Should this also be hidden? 6) 'Delete template' is greyed out, when no template is selected, but 'Apply template' is always active. Should we make 'Apply template' also depend on having a template selected first? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
