https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
--- Comment #84 from Nick Clemens <[email protected]> --- Created attachment 142859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142859&action=edit Bug 30982: [22.05.x] Use the REST API for background job list view Bug 30982: REST API specs Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: (QA follow-up) Double quoting and console.log This patch fixes the issues highlighted by the QA script; We use double quotes for translatable strings in JS and remove an errant console.log call. Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: Add tests and implement GET /background_jobs/$id Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: Make code more re-usable Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: Add 'context' to the REST API specs context has been added by bug 30889 Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: Add Koha::BackgroundJobs->filter_by_current Signed-off-by: Tomas Cohen Arazi <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: API tweaks This patch makes the following changes to the 'background_jobs' API: * We now call them 'jobs' * Removed deprecated query parameter definitions * Added only_current query parameter * Controller gets adapted to use $rs->filter_by_current when only_current is passed Signed-off-by: Tomas Cohen Arazi <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: Adapt table to new API spec Disclaimer: this patch is highly opinionated :-D When I started looking at this patch I felt like the two tables (current/past jobs) implemented on bug 30462 was the way to go. In order to make this patches apply after it I had to redo all the things. Or most of them. But I decided to keep the idea of filtering out completed tasks, not just having the option to display 'the last hour' tasks. For the task I added some required helper methods and the relevant tests as well. So a behavior change. Hope you all agree with it. Signed-off-by: Tomas Cohen Arazi <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: Rename 'Background Jobs' => 'Jobs' Signed-off-by: Tomas Cohen Arazi <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: (QA follow-up) Resolve pod warning Empty section in previous paragraph at line 32 in file Koha/BackgroundJobs.pm Test plan: Run podchecker again on this module. Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: (QA follow-up) Spelling [1] Correct: BackgrounJob [2] If should filter out not current jobs => Had a hard time reading that one until I replaced if by it. => Decided to rephrase it in a more positive way. Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: (QA follow-up) Remove redundancy from template The template now contains two lists for both status and type: a TT list and a JS list. The type list already proves that redundancy leads to bugs. We miss three types at one side: Unknown job type 'stage_marc_for_import' Unknown job type 'marc_import_commit_batch' Unknown job type 'marc_import_revert_batch' This patch removes the TT list. And gets the status and type via an additional js call. For that reason I hide the fieldset until document ready. This can be improved later when needed. Test plan: Look at status and type on both job list and detail view. Signed-off-by: Marcel de Rooy <[email protected]> Bug 30982: (QA follow-up) No userenv, no jobs + # Assume permission if context has no user + my $can_manage_background_jobs = 1; => This felt a bit unsafe. Test plan: Try interface for jobs. Call API with cookie. Call API with OAuth. Run t/db_dependent/Koha/BackgroundJobs.t Signed-off-by: Marcel de Rooy <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
