https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813
--- Comment #43 from David Cook <dc...@prosentient.com.au> --- (In reply to David Cook from comment #42) > I like a lot of things from these patches, but I reckon they could probably > be broken up into a number of smaller issues. - Refactor C4::Auth::getuserflags() and move to Koha::Auth::Permissions->get_flags() with unit tests - Refactor Koha::Auth::Permissions->get_authz_from_flags to build a fully populated authz hash, and then create Koha::Auth::Permissions->get_template_authz_from_authz() - Refactor C4::Auth::haspermission() (this is actually used more extensively through Koha than I originally thought...) - Update Acquisition.pm, Budgets.pm, about.pl, and other users of authorization data checks outside of the initial AuthZ check on page load... The goal of the above is to centralize the business logic of permission/authorization checks in Koha, so we're not repeating complex code structures throughout the app. - Finally, move "flags" column into "user_permissions" table (that said, this could have unexpected consequences for borrower_modifications and deletedborrowers...)(this also will have consequences with manual SQL and tests) The goal of the above is to free us from the bit-packed "flags" integer and separate sub-permission table, so that it's easier to create and organise flags/permissions. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
