https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
--- Comment #256 from Martin Renvoize <[email protected]> --- (In reply to David Nind from comment #235) > I've retested and here are some more comments. Thank you so much for persevering here :) > 1. When submitting a concern on the OPAC, there is no acknowledgement > message, for example like when you report a problem or make a purchase > suggestion (such as, "Your catalog concern report was submitted.") - you are > just returned to the record. Added now to the OPAC.. I didn't add it to the staff client yet, I wasn't sure it was as important here. > 2. Last comment/update is prepopulated into the update field without a hard > page refresh: > 2.1 Click on the Details action for a concern > 2.2 Add a comment in the update field and click on comment > 2.3 Click on the details action again for the same concern without > refreshing the page: note that the update field is populated with the last > comment made > 2.4 Click on another concern: same results as 2.3 > 2.5 If you click away to another page (or a hard referesh - Shift + > Refresh), and then go back to the catalog concerns page this doesn't happen. This should be resolved now. > 3. Permissions to manage concerns - I still can't get this to work using the > editcatalog permission: > 3.1 I added the editcatalog permission + all tools to a staff user > (Henry). > 3.2 When I go to access catalog concerns (either from 'Pending catalog > concerns' on the home page or from the cataloging home page), I get "You do > not have permission to access this page" and the login form. > 3.3 Without the permission, I don't see 'Pending catalog concerns' on the > home page or "Catalog concerns" on the Cataloguing home page (as expected). > 3.4 I also gave all permissions except "Access to all librarian functions > (superlibrarian)" and I still get the same permission error as in 3.2. Great work spotting this one, there was a misnamed permission on my part in the code. Fixed now. > 4. Details of concerns listed on the record details page are now shown, > however: > 4.1 If resolved, can still add comments, and can also click on resolve > again (using the koha superlibrarian user). > 4.2 Whereas, in the Cataloging > Catalog concerns area, once you have > resolved the concern the only option you have is the "Comment" button. > 4.2 If you don't have permission, can see the details in modal window and > the Resolve and Comment buttons are displayed. When attempting to make a > comment or resolve, the modal sits there with the "spinner" on the button. This should now match the main concern management page. > 5. Reporting a catalog concern from the staff interface - display of help > text: > 5.1 If the help text has a bulleted list, the bullets aren't shown (add > some lines to the help text, make them into a bulleted list, report a > problem in the staff interface for a record). Resolved, but required a CSS rebuild to test > 6. Notices sent using email (see [1] for how I set up to test): > 8.1 Acknowledgement, update, and resolved notifications come through > (acknowledgement messages came straight through, but update and resolved came > through when I ran misc/cronjobs/process_message_queue.pl). Timing is as designed, acknowledgement is immediate, other notices are queued. > 8.2 The notify message to CatalogersEmail address didn't come through and > is not in the message queue. I can't seem to replicate this not coming through.. - Perhaps the empty CatalogersEmail preference was cached? > 8.3 Messages come through as a single line without any line breaks. Does > the notice need HTML tags for this? See [2] for examples of what was > received. This should be resolved now by dropping the 'is_html' flag. > 8.4 Only the 'Catalog concern updated' and 'Catalog concern resolved; > notices were displayed under the patron's record of notices - the > acknowledgement notice wasn't listed. Acknowledgement should now also show here. > 7. Setting CatalogerEmails - wrong name in test plan for patch 'Add email > notification of cataloguers on submissions' (CataloguerEmails should be > CatalogerEmails. Corrected, but I also noticed you cannot enter a comma delimited list.. I think it's OK to only allow one email address for now. > 8. List of concerns - should it default to only displaying the unresolved > concerns? Otherwise, the list could get quite long... Maybe this should be a > separate bug if considered an issue, as I noticed that this is the same > pattern used for OPAC problem reports and AllowCheckoutNotes. Good idea, but I agree perhaps it's one for a later bug. > [1] Set up for testing notifications using Gmail when using KTD. Add this to > /etc/koha/sites/kohadev/koha-conf.xml, setup an App password for your Gmail > account, add the details as indicated, and add your Gmail address as the > email for a patron(s) used in testing: > > <smtp_server> > <host>smtp.gmail.com</host> > <port>587</port> > <timeout>5</timeout> > <ssl_mode>STARTTLS</ssl_mode> > <user_name>YOURGMAILADDRESS</user_name> > <password>YOURAPPPASSWORD/password> > <debug>1</debug> > </smtp_server> > > [2] Text of email messages - came through as a single line: > > Acknowledgement: > > Dear koha (42), Thankyou for your report concerning Lady Susan ; The Watsons > ; Sanditon / . You reported: **Describe the concern** A clear and concise > description of what the concern is. **To Reproduce** Steps to reproduce the > behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See > error **Expected behavior** A clear and concise description of what you > expected to happen. Thankyou > > Update: > > Dear koha (42), The library has added an update to the concern you reported > against Lady Susan ; The Watsons ; Sanditon / . The following comment was > left: Send an update Thankyou > > Resolved: > > Dear koha (42), The library has now marked your concern with Lady Susan ; > The Watsons ; Sanditon / as resolved. The following comment was left: This > is now fixed! Thankyou -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
