http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9523
--- Comment #3 from Kyle M Hall <[email protected]> --- You are correct. I'll post up a corrected patch when I can. Kyle (In reply to comment #2) > Your patch changes the query to > > SELECT candidate_match_id > LEFT JOIN biblio ON ( candidate_match_id = biblionumber ) > FROM import_record_matches > WHERE import_record_id = ? > ORDER BY score DESC, candidate_match_id DESC; > > This is invalid SQL ... JOIN clauses come after FROM clauses. Even were the > SQL statement constructed correctly, the left join by itself would make no > difference to the query results, as the candidate_match_ids would get > returned whether or not the matching bib was still attached. > > The patch might *appear* to work, but would have the effect of > unconditionally all bibs in the import batch, regardless of matches. > > As a note for testing, I suggest using the command-line staging import > tools, as they reproduce the problem *and* give useful output in the case of > a failure. For example, if you follow the reproduction steps but use the > command-line tools to commit the batch, you get the following error: > > $ misc/commit_file.pl --batch-number 5 > ... importing MARC records -- please wait > Empty String at /usr/lib/perl5/XML/LibXML/SAX/Parser.pm line 42 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
