https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298
--- Comment #4 from Katrin Fischer <[email protected]> --- Hi Matt, congrats on your first patch! :) Some small stuff: * The commit message always needs to start with: Bug XXXX: - this helps with our tools and also gives some consistency in the commit message. You can find information on how to write good commit messages in the wiki: https://wiki.koha-community.org/wiki/Commit_messages. If you run the qa test tools on your patches, they will also alert you of issues like this. on ktd in the shell: qa -v 2 * Not a problem, but maybe you'd want to change the first bit to use a formatted name: mattblenkinsop <[email protected]>. This should come from GIT_USER_NAME= in the .env of ktd. I have Katrin Fischer there and it works with the blank and without quotes. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
