https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #2 from Tomás Cohen Arazi <[email protected]> --- Comment on attachment 144401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144401 Bug 32393: Prevent invalid job to block the job queue Review of attachment 144401: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32393&attachment=144401) ----------------------------------------------------------------- ::: misc/background_jobs_worker.pl @@ +104,5 @@ > + Koha::Logger->get->warn(sprintf "Job and/or frame not processed > - %s", $_); > + } finally { > + $job->status('failed')->store if $job; > + $conn->ack( { frame => $frame } ); > + }; The finally block is always executed regardless of the exit status of the try block. It reads wrong to be setting the status as failed. That line belongs to the catch IMHO. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
