https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254
Nick Clemens <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Nick Clemens <[email protected]> --- (In reply to Marcel de Rooy from comment #14) > A first glance tells me: The unit test does not cover all changes made in > the second patch. There is a huge amount of changed lines and only one very > trivial test that does not convince me at all. git diff -w HEAD~3.. Koha/Item.pm It changes three lines to prevent sending a 'lost_charge' message when there is no charge to replace The test fails before, and passes after and other behaviour is covered by _set_found_trigger tests. I agree, expanding coverage is good, but should be on another bug -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
